Remove the legacy extension identifier-matching code by isaacroldan · Pull Request #8049 · Shopify/cli

isaacroldan · 2026-07-09T19:19:22Z

Part 8 of 8 — splitting #8040.

WHY are these changes introduced?

With deploy switched to active-app-version classification (#8056), the Partners-era matching subsystem is dead code.

WHAT is this pull request doing?

Deletes id-matching, id-manual-matching, identifiers-extensions, ensureDeploymentIdsPresence, the match/select prompts, and the deploy-path breakdown helpers.
Relocates the still-used LocalRemoteSource / getExtensionIds into migrate-app-module.
Reshapes updateAppIdentifiers to take an app API key + flat UUID map; drops the dead Identifiers types and the unused rewriteConfiguration helper.

Pure cleanup — no behavior change (~3,400 lines removed).

How to test your changes?

pnpm --filter @shopify/app exec vitest run (full app suite)

isaacroldan · 2026-07-09T19:19:35Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

isaacroldan · 2026-07-10T15:43:18Z

/snapit

isaacroldan · 2026-07-10T15:55:01Z

/snapit

isaacroldan · 2026-07-14T07:45:48Z

/snapit

App Management is the only developer platform client now that all organizations are migrated, so drop the Partners client, its GraphQL operations, and the Partners branch of org/app discovery and selection. `app dev` and `deploy` no longer contact the Partners API, so local development no longer needs the `partners` dev service or SHOPIFY_CLI_NEVER_USE_PARTNERS_API. Also remove the Partners-era legacy extension migrations that ran during deploy: they only ever worked against the Partners API (App Management throws "Not implemented" for those mutations). Stacked on top of #8049 (top of Isaac's deploy-split stack). Co-authored-by: Craig Martin <craig.martin@shopify.com> Co-authored-by: Nick Wesselman <nick.wesselman@shopify.com>

isaacroldan · 2026-07-14T08:04:58Z

/snapit

github-actions · 2026-07-14T08:08:06Z

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260714080552

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

App Management is the only developer platform client now that all organizations are migrated, so drop the Partners client, its GraphQL operations, and the Partners branch of org/app discovery and selection. `app dev` and `deploy` no longer contact the Partners API, so local development no longer needs the `partners` dev service or SHOPIFY_CLI_NEVER_USE_PARTNERS_API. Also remove the Partners-era legacy extension migrations that ran during deploy: they only ever worked against the Partners API (App Management throws "Not implemented" for those mutations). Stacked on top of #8049 (top of Isaac's deploy-split stack). Co-authored-by: Craig Martin <craig.martin@shopify.com> Co-authored-by: Nick Wesselman <nick.wesselman@shopify.com>

github-actions · 2026-07-14T14:49:04Z

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

Some seemingly private modules might be re-exported through public modules.
If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts

@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.4.0";
\ No newline at end of file

Deletes the now-unused Partners-era matching subsystem (id-matching, id-manual-matching, identifiers-extensions, ensureDeploymentIdsPresence, the match/select prompts, and the deploy-path breakdown helpers) now that deploy classifies against the active app version. Relocates the still-needed `LocalRemoteSource`/`getExtensionIds` into migrate-app-module, reshapes `updateAppIdentifiers` to take an app API key and a flat UUID map, drops the dead `Identifiers` types and the unused `rewriteConfiguration` helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Assisted-By: devx/082b4d86-7362-4c41-a55c-65a391c27853

This was referenced Jul 9, 2026

Add order-insensitive deep object comparison to cli-kit #8044

Merged

Classify webhook subscription modules as configuration experience #8045

Merged

This was referenced Jul 9, 2026

Fix webhook subscription UID to omit the literal "undefined" for absent filters #8046

Merged

Make deploy consumers speak app-module UUID/registration-ID maps #8047

Merged

Derive deploy identifiers from the active app version #8048

Closed

github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 9, 2026

isaacroldan changed the base branch from deploy-split/05-active-app-version-classification to graphite-base/8049 July 10, 2026 11:11

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from 8ade7c3 to fe0efb8 Compare July 10, 2026 11:11

isaacroldan force-pushed the graphite-base/8049 branch from 9d690a9 to d8abcc9 Compare July 10, 2026 11:11

isaacroldan changed the base branch from graphite-base/8049 to deploy-split/05c-switch-deploy July 10, 2026 11:11

This was referenced Jul 10, 2026

Rework release config diff to compare version against active version #8054

Open

Add active-app-version deploy classification module #8055

Open

Switch deploy to the active-app-version classification #8056

Open

isaacroldan changed the base branch from deploy-split/05c-switch-deploy to graphite-base/8049 July 10, 2026 11:28

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from fe0efb8 to 4a943bc Compare July 10, 2026 11:56

isaacroldan changed the base branch from graphite-base/8049 to deploy-split/05c-switch-deploy July 10, 2026 11:57

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 7a73d6c to 346a29f Compare July 10, 2026 12:06

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch 2 times, most recently from 7ef2ab5 to 4cbf112 Compare July 10, 2026 12:56

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch 2 times, most recently from 3036c8c to 644c235 Compare July 10, 2026 13:45

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch 2 times, most recently from b870535 to 8c16ffc Compare July 10, 2026 14:54

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 644c235 to 3260c7b Compare July 10, 2026 14:54

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 3260c7b to c283e20 Compare July 10, 2026 15:54

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from 8c16ffc to 4f9d872 Compare July 10, 2026 15:54

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from c283e20 to 8876f69 Compare July 14, 2026 07:44

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from 4f9d872 to a513e21 Compare July 14, 2026 07:44

isaacroldan mentioned this pull request Jul 14, 2026

Remove the Partners API developer platform client from app commands #8079

Closed

4 tasks

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from a513e21 to ab7fbc2 Compare July 14, 2026 08:04

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 8876f69 to 8c9c96f Compare July 14, 2026 08:04

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 8c9c96f to 6f5abbc Compare July 14, 2026 09:52

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from ab7fbc2 to 511d329 Compare July 14, 2026 09:52

isaacroldan marked this pull request as ready for review July 14, 2026 10:56

isaacroldan requested a review from a team as a code owner July 14, 2026 10:56

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 6f5abbc to c583dc4 Compare July 14, 2026 11:10

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from 511d329 to 4f266a7 Compare July 14, 2026 11:10

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch from 4f266a7 to ea143ac Compare July 14, 2026 13:52

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from c583dc4 to 2991088 Compare July 14, 2026 13:52

isaacroldan and others added 2 commits July 14, 2026 17:05

Merge current account info helpers

529b34e

Assisted-By: devx/082b4d86-7362-4c41-a55c-65a391c27853

isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 2991088 to 9ea4edb Compare July 14, 2026 15:06

isaacroldan force-pushed the deploy-split/06-remove-legacy-matching branch 2 times, most recently from 0c8add0 to 529b34e Compare July 14, 2026 15:06

Update command snapshot after restack

1eef387

Assisted-By: devx/082b4d86-7362-4c41-a55c-65a391c27853

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove the legacy extension identifier-matching code#8049

Remove the legacy extension identifier-matching code#8049
isaacroldan wants to merge 3 commits into
deploy-split/05c-switch-deployfrom
deploy-split/06-remove-legacy-matching

isaacroldan commented Jul 9, 2026 •

edited

Loading

Uh oh!

isaacroldan commented Jul 9, 2026 •

edited

Loading

Uh oh!

isaacroldan commented Jul 10, 2026

Uh oh!

isaacroldan commented Jul 10, 2026

Uh oh!

isaacroldan commented Jul 14, 2026

Uh oh!

isaacroldan commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

isaacroldan commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Uh oh!

isaacroldan commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isaacroldan commented Jul 10, 2026

Uh oh!

isaacroldan commented Jul 10, 2026

Uh oh!

isaacroldan commented Jul 14, 2026

Uh oh!

isaacroldan commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Differences in type declarations

New type declarations

Existing type declarations

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

isaacroldan commented Jul 9, 2026 •

edited

Loading

isaacroldan commented Jul 9, 2026 •

edited

Loading